Skip to content

FINERACT-2326: Refactor trial balance processing to reduce cognitive complexity #5179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

FINERACT-2326: Refactor trial balance processing to reduce cognitive complexity #5179

wants to merge 1 commit into from
+74 −43

Conversation

@a7med3del1973
Copy link
Contributor

@a7med3del1973 a7med3del1973 commented Nov 25, 2025

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

IOhacker
IOhacker requested changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate how it improves the changes in the Trial Balance Processing ? Any financial user has sent a report about an issue with this feature?

@a7med3del1973
Copy link
Contributor Author

a7med3del1973 commented Nov 26, 2025

Could you please elaborate how it improves the changes in the Trial Balance Processing ? Any financial user has sent a report about an issue with this feature?

There's no user reported issues the matter related with maintained code is more readable, focused methods and consolidating duplicated logic

@adamsaghy
Copy link
Contributor

adamsaghy commented Dec 1, 2025

@a7med3del1973 FINERACT-2181 is closed story. Please kindly use FINERACT-2326 instead.

adamsaghy
adamsaghy requested changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly see my request.

@a7med3del1973 a7med3del1973 changed the title FINERACT-2181: Refactor trial balance processing to reduce cognitive complexity FINERACT-2236: Refactor trial balance processing to reduce cognitive complexity Dec 2, 2025
@adamsaghy
Copy link
Contributor

adamsaghy commented Dec 2, 2025

@a7med3del1973 FINERACT-2326

@adamsaghy
Copy link
Contributor

adamsaghy commented Dec 2, 2025

@IOhacker Seems like this is only refactor for readability, no functional changes AFAIK.

@a7med3del1973 a7med3del1973 changed the title FINERACT-2236: Refactor trial balance processing to reduce cognitive complexity FINERACT-2326: Refactor trial balance processing to reduce cognitive complexity Dec 2, 2025
@adamsaghy
Copy link
Contributor

adamsaghy commented Dec 3, 2025

@a7med3del1973 Since you are refactoring this piece of code. Would it make sense to rewrite to use JQPL instead of native queries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IOhacker IOhacker Awaiting requested review from IOhacker

@adamsaghy adamsaghy Awaiting requested review from adamsaghy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a7med3del1973 @adamsaghy @IOhacker